2019-04-16, 10:04 AM
(2019-04-15, 11:12 PM)Y_Less Wrote: The old BCrypt plugin used a callback architecture. ?You requested a hash, and once it was done the plugin informed you. ?This was because cryptographic hashes are meant to be slow. ?Their security lies in the fact that they take a long time to calculate, making brute-forcing them impossible within the age of the universe. ?Performing the hash synchronously as in this version would stall the server for a non-trivial amount of time while running the calculation. ?I like the presence of multiple different hashes, but this should really be threaded.
Threading has been suggested to me before, I just never got around to doing it. Argon2 already has threading (in the form of lanes? idk, you'll have to check out the rust-argon2 crate) so that's probably the best to use. I'll look into doing this, and if anyone decides they want to make a PR why not :)
Also I do know that it did use a callback architecture, and if anyone prefers that you've always got SyS' bcrypt plugin, and that's still being maintained as is this plugin. This is just meant to be a drop-in replacement for 'legacy' hashing methods (SHA256_PassHash, Whirlpool, MD5, etc).